Quantcast
Channel: SBFspot Issue Tracker Rss Feed
Viewing all articles
Browse latest Browse all 360

Commented Unassigned: MYSQL_BIND.is_null assignment in db_MySQL_Export.cpp breaks build [172]

$
0
0
in db_MySQL_Export.cpp the is_null member of all column bindings is explicitly set to false.

The MySQL API defines is_null as a pointer to my_bool and not as a my_bool. While setting the value to false produces working code, it violates strict error checking rules and consequently breaks the build. Experience on Debian Stretch, gcc version 6.2.1 20161124 (Debian 6.2.1-5)

Since the binding array memory is zero initialised using memset, the is_null pointers will be NULL automatically so there is no use in explicitly assigning them.

Attached patch removes all the is_null assignments.

Comments: Thank you for your contribution, but there was already a patch (3.3.2) available See [Doesn't compile with gcc 6.1.1 (Fedora 24) ](https://sbfspot.codeplex.com/workitem/160) If the array is zero filled like you say, the is_null assignments are redundant. Thanks

Viewing all articles
Browse latest Browse all 360

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>